Parallel tests fail on upgrades #226
Assignees
Labels
bug
Something isn't working
Comments
Ngalstyan4
added a commit
that referenced
this issue
Nov 18, 2023
Fix wront return code check Add index validation functions to update script Fix update test runner logic We used to run new tests on the old DB. This need not always succeed as new tests may use/test functionality from the newer version of the DB. In the new approach, we only run tests *after* upgrade script has been run. Make common.sql idempotent Suppress common output and add update comments Rename main -> from_tags[-1] in update script Do not fail on parallel test failure during update (tracked by #226)
Ngalstyan4
added a commit
that referenced
this issue
Nov 18, 2023
Fix wront return code check Add index validation functions to update script Fix update test runner logic We used to run new tests on the old DB. This need not always succeed as new tests may use/test functionality from the newer version of the DB. In the new approach, we only run tests *after* upgrade script has been run. Make common.sql idempotent Suppress common output and add update comments Rename main -> from_tags[-1] in update script Do not fail on parallel test failure during update (tracked by #226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Parallel tests (inserts, in particular) often fail with an error message when running upgrade script from 0.0.4 to 0.05:
Note that in upgrade process,
begin.sqlruns with the old extension version, while the rest of the tests run with the newer version of the extension.See an example failure here: https://github.com/lanterndata/lantern/actions/runs/6910547384/job/18803850282?pr=223
I have not disabled these update tests but have just made sure they do not result in the failure of the whole suite. So, to debug this, you can make a regular PR and see the failure logs under "Run update tests linux" subsection of the CI log
The text was updated successfully, but these errors were encountered: