Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarking to local dev and to CI/CD #100

Merged
merged 19 commits into from
Sep 2, 2023
Merged

Add benchmarking to local dev and to CI/CD #100

merged 19 commits into from
Sep 2, 2023

Conversation

dqii
Copy link
Contributor

@dqii dqii commented Aug 31, 2023

image

@dqii dqii requested a review from Ngalstyan4 August 31, 2023 05:53
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #100 (a411766) into main (1880d37) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   83.19%   83.19%           
=======================================
  Files          13       13           
  Lines         940      940           
  Branches      185      185           
=======================================
  Hits          782      782           
  Misses         71       71           
  Partials       87       87           

@dqii dqii force-pushed the @di/add-benchmarking branch 4 times, most recently from e61cae2 to 453acd4 Compare September 1, 2023 02:31
@dqii dqii force-pushed the @di/add-benchmarking branch from 453acd4 to 60e59af Compare September 1, 2023 02:35
@dqii
Copy link
Contributor Author

dqii commented Sep 1, 2023

Just documenting the current state.

make benchmark runs locally for me.

The pip install's don't work in CI/CD unless you remove --break-system-packages. This breaks local for me.
If you remove --break-system-packages, it still doesn't work because the DATABASE_URL's are wrong.

@dqii dqii changed the title Add benchmarking script to CMakeLists.txt Add benchmarking script to local dev and to CI/CD Sep 1, 2023
@dqii dqii changed the title Add benchmarking script to local dev and to CI/CD Add benchmarking to local dev and to CI/CD Sep 1, 2023
@dqii
Copy link
Contributor Author

dqii commented Sep 1, 2023

Update:

  • make benchmark runs locally for me.

Two issues:

  • The database URLs are incorrect in run_benchmarks and cause CI/CD to not work.
  • Despite the fact that CI/CD didn't work, it's marked as passing when it shouldn't be.

@dqii dqii marked this pull request as draft September 1, 2023 18:45
@dqii dqii force-pushed the @di/add-benchmarking branch from a5d69a8 to c53630b Compare September 1, 2023 18:53
@dqii dqii marked this pull request as ready for review September 2, 2023 04:35
@dqii dqii requested a review from var77 September 2, 2023 04:35
@dqii
Copy link
Contributor Author

dqii commented Sep 2, 2023

All issues are fixed.

@dqii dqii merged commit 86c90be into main Sep 2, 2023
var77 added a commit that referenced this pull request Oct 8, 2024
* Change channels to unbounded channles, add debug logs

* Add more debug logs

* Change atomic  to channel add debug logs

* Fix http tests

* Bump version [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants