cleanup: get rid of unnecessary markbufferdirty and field #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at test failure. |
This commit does 3 things: - Get rid of index_rel from ExtraDirtiedBufs as it's not used - Rename ExtraDirtiedBufs fields to be lower case instead of upper case. Based on Narek, they were upper case before to indicate they could only be touched/modified once across all threads (i.e. the variables were global) - Get rid of unnecessary MarkBufferDirty. In cases where a buffer is tracked by xlog, GenericXLogFinish will call MarkBufferDirty so we don't need to call it ourselves.
Hi @yoloVoe , the test failure was caused as we have replaced the usearch index files with newer versions under the same url, which were being used in an existing tests with old usearch version. This should be fixed now, sorry for inconvenience. |
|
Ah, I see. Thanks for the update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does 3 things: