Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect correct operator usage using AST #111

Merged
merged 23 commits into from
Sep 5, 2023
Merged

Detect correct operator usage using AST #111

merged 23 commits into from
Sep 5, 2023

Conversation

dqii
Copy link
Contributor

@dqii dqii commented Sep 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 3, 2023 •
edited
Loading

Codecov Report

Merging #111 (b0cffd1) into main (5c794a4) will increase coverage by 0.34%.
Report is 5 commits behind head on main.
The diff coverage is 85.45%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   83.87%   84.22%   +0.34%     
==========================================
  Files          13       14       +1     
  Lines         949     1046      +97     
  Branches      185      232      +47     
==========================================
+ Hits          796      881      +85     
- Misses         67       74       +7     
- Partials       86       91       +5
Files Changed Coverage Δ
src/hnsw/utils.c 85.71% <ø> (-1.52%) ⬇️
src/hnsw/options.c 85.93% <63.63%> (+0.45%) ⬆️
src/parser/parse_op.c 87.75% <87.75%> (ø)
src/hnsw.c 83.14% <100.00%> (+1.45%) ⬆️

... and 4 files with indirect coverage changes

@dqii dqii linked an issue Sep 4, 2023 that may be closed by this pull request
Forbid standalone usage of <-> operator using statement AST #56
Closed
@dqii dqii changed the title Initial support for AST-based operator validation AST-based operator validation Sep 4, 2023
@dqii
Copy link
Contributor Author

dqii commented Sep 4, 2023 •
edited
Loading

  • Clean up code (move to separate file)
  • Improve test coverage
  • Handle Postgres versions
  • Handle more cases (e.g., MAX)

@dqii dqii force-pushed the @di/support-ast-validation branch from 422f1e8 to c8664af Compare September 4, 2023 16:27
@dqii dqii changed the title AST-based operator validation Detect correct operator usage using AST Sep 4, 2023
@dqii dqii marked this pull request as ready for review September 5, 2023 02:27
Ngalstyan4
Ngalstyan4 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dqii dqii merged commit 6ebac12 into main Sep 5, 2023
@dqii dqii deleted the @di/support-ast-validation branch September 5, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ngalstyan4 Ngalstyan4 Ngalstyan4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forbid standalone usage of <-> operator using statement AST
2 participants
@dqii @Ngalstyan4