Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang format not correctly applied to C files #115

Merged
merged 3 commits into from
Sep 7, 2023
Merged

Conversation

dqii
Copy link
Contributor

@dqii dqii commented Sep 5, 2023

SOURCES in the file() function does not expand. It will try to find a file or directory literally named by the value of ${SOURCES} which is not desired.

SOURCES in the file() function does not expand. It will try to find a
file or directory literally named by the value of ${SOURCES} which is
not desired.
@dqii dqii requested a review from Ngalstyan4 September 5, 2023 00:55
@dqii dqii marked this pull request as ready for review September 5, 2023 00:57
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #115 (f8f8926) into main (4646afc) will decrease coverage by 0.33%.
The diff coverage is 80.00%.

❗ Current head f8f8926 differs from pull request most recent head cbd8fd8. Consider uploading reports for the commit cbd8fd8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   84.28%   83.96%   -0.33%     
==========================================
  Files          13       13              
  Lines        1069      979      -90     
  Branches      238      194      -44     
==========================================
- Hits          901      822      -79     
+ Misses         74       68       -6     
+ Partials       94       89       -5     
Files Changed Coverage Δ
src/hnsw/extra_dirtied.c 85.71% <ø> (ø)
src/hnsw.c 83.14% <76.92%> (ø)
src/hnsw/insert.c 80.70% <100.00%> (ø)

... and 7 files with indirect coverage changes

@dqii dqii force-pushed the @di/fix-clang-format branch from f8f8926 to e67032c Compare September 5, 2023 01:12
@dqii dqii merged commit 0cd5cdb into main Sep 7, 2023
@dqii dqii deleted the @di/fix-clang-format branch September 7, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants