Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test runner for OS X, fix checking pgvector in tests #119

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Sep 5, 2023

Changed grep -P to perl as -P option is no longer supported on OS X. reference

Changed the database name when checking if pgvector is installed to postgres, as now it defaults to current os username and it may fail.

Removed timing from explains, removed ids from select as if 2 vectors would have the same distance the order might be different based on machine and test might fail

@var77 var77 requested review from Ngalstyan4 and dqii September 5, 2023 20:55
@Ngalstyan4 Ngalstyan4 merged commit f842b4a into lanterndata:main Sep 6, 2023
var77 added a commit that referenced this pull request Oct 8, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
* add code coverage info

* fix pg folder permissions

* add codecov conf, make tests more deterministic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants