Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce elog overhead on fastpath #120

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

Ngalstyan4
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 commented Sep 6, 2023

Should be merged now.

  • Add a CmakeLists option for defining LANTERNDB_DEBUG_LOGS
  • Build LanternDB with LANTERNDB_DEBUG_LOGS in ci/cd for tests
  • Separate out tests that need LANTERNDB_DEBUG_LOGS into one file (This will make sure that if users run tests locally, without enabling this flag on their release branch, tests only in one file will fail)

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #120 (678f229) into main (9df32a0) will increase coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   84.01%   84.20%   +0.18%     
==========================================
  Files          17       17              
  Lines        1170     1165       -5     
  Branches      250      245       -5     
==========================================
- Hits          983      981       -2     
  Misses         85       85              
+ Partials      102       99       -3     
Files Changed Coverage Δ
src/hnsw/scan.c 83.50% <ø> (+2.13%) ⬆️
src/hnsw/utils.h 40.00% <ø> (ø)

@Ngalstyan4 Ngalstyan4 force-pushed the narek/reduce-log-overhead branch from 608e91a to 50fb695 Compare September 10, 2023 23:24
@Ngalstyan4
Copy link
Contributor Author

Actually, seems kind of annoying to have yet another build option for this..
Opened an issue (#133) to deal with this in a cleaner way

@Ngalstyan4 Ngalstyan4 force-pushed the narek/reduce-log-overhead branch from 50fb695 to 678f229 Compare September 10, 2023 23:43
@Ngalstyan4 Ngalstyan4 requested a review from dqii September 10, 2023 23:45
@Ngalstyan4 Ngalstyan4 merged commit c65ca02 into main Sep 11, 2023
@Ngalstyan4 Ngalstyan4 deleted the narek/reduce-log-overhead branch September 11, 2023 00:06
var77 added a commit that referenced this pull request Oct 8, 2024
* add daemon functions in lantern_extras extension

* add GUC for daemon target database list

* add tests for daemon functions

* enable daemon by default for tests

* configure postgresql.conf for daemon tests

* make daemon sql test more deterministic

* handle already exists error

* make functions as security definer and update README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant