Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable codecov check only for prs #123

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Sep 7, 2023

This PR will change the codecov default behaviour to run only on pull requests, so we won't have the failure checkmark on main branch in case of codecov failure

@var77 var77 requested a review from Ngalstyan4 September 7, 2023 19:05
@Ngalstyan4
Copy link
Contributor

Ngalstyan4 commented Sep 8, 2023

  1. Once we merge this, where will the coverage number on the readme badge come from? Latest merged PR? some other PR? Somewhere else?
  2. Is there a way to run code coverage on main but just not consider a coverage decrease a failure?

@var77
Copy link
Collaborator Author

var77 commented Sep 8, 2023

No it will upload the coverage information anyway from our CI, so the badge will be updated. Just the codecov bot won't trigger it's checks on push actions, but it will run on PRs

@Ngalstyan4 Ngalstyan4 merged commit 3c2bcd8 into lanterndata:main Sep 8, 2023
var77 added a commit that referenced this pull request Oct 8, 2024
* add splade v3 model

* Add new splade-v3 model change rwlock to mutex to avoid race conditions

* add github badges

* update cli version in github action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants