Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark comment #127

Merged
merged 3 commits into from
Sep 10, 2023
Merged

Add benchmark comment #127

merged 3 commits into from
Sep 10, 2023

Conversation

dqii
Copy link
Contributor

@dqii dqii commented Sep 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #127 (6ce3111) into main (bfdd818) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #127   +/-   ##
=======================================
  Coverage   84.28%   84.28%           
=======================================
  Files          13       13           
  Lines        1069     1069           
  Branches      238      238           
=======================================
  Hits          901      901           
  Misses         74       74           
  Partials       94       94           

@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 0.00%
recall (after insert) 0.784 0.784 0.00%
select tps 2969.562 3925.674 32.20%
select latency (ms) 1.787 1.481 -17.12%
create latency (ms) 1658.671 1614.639 -2.65%
insert latency (ms) 1.904 1.706 -10.40%
insert tps 525.020 585.919 11.60%
disk usage (bytes) 6348800.000 6348800.000 0.00%

@dqii dqii requested a review from Ngalstyan4 September 9, 2023 19:05
@dqii dqii marked this pull request as ready for review September 9, 2023 19:05
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dqii dqii merged commit ae805e8 into main Sep 10, 2023
@dqii dqii deleted the @di/benchmark-comment branch September 10, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants