Add pgvector 0.5.0+ vector type compatibility #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 84.27% 84.01% -0.26%
==========================================
Files 17 17
Lines 1170 1170
Branches 249 250 +1
==========================================
- Hits 986 983 -3
- Misses 79 85 +6
+ Partials 105 102 -3
|
Ngalstyan4
force-pushed
the
narek/pgvector-compat
branch
from
1029c79 to
5bc2136
Compare
Benchmarks
|
Ngalstyan4
changed the title
|
Looks good, just we need to change the pgvector version in CI build script as well https://github.com/lanterndata/lanterndb/blob/main/ci/scripts/build-linux.sh#L33 |
Ngalstyan4
force-pushed
the
narek/pgvector-compat
branch
from
0abb050 to
090c22d
Compare
dqii
reviewed
Sep 10, 2023
| foreach(lc, queryDesc->plannedstmt->subplans) { | ||
| Plan *subplan = (Plan *)lfirst(lc); | ||
| validate_operator_usage(subplan, oidList); | ||
| if(oidList != NULL) { |
There was a problem hiding this comment.
I think these changes weren't intended.
There was a problem hiding this comment.
Small typo re: CRETE. Otherwise, discussed offline, these changes were intended.
dqii
reviewed
Sep 10, 2023
ci/scripts/build-linux.sh
Outdated
| wget -O pgvector.tar.gz https://github.com/pgvector/pgvector/archive/refs/tags/v${PGVECTOR_VERSION}.tar.gz | ||
| tar xzf pgvector.tar.gz | ||
| pushd pgvector-${PGVECTOR_VERSION} | ||
| make && make install | ||
| popd | ||
| popd | ||
| # Fix pg_config (sometimes it points to wrong version) |
There was a problem hiding this comment.
Did you intend to remove this comment?
dqii
approved these changes
Sep 10, 2023
Ngalstyan4
force-pushed
the
narek/pgvector-compat
branch
from
090c22d to
0924865
Compare
This actually happened... Some of our getters had exactly same names as recently added pgvector hnsw index getter names. This caused issues when our extension was installed after installing pgvector: homonymous lantern functions would resolve to pgvector's functions and we would get wrong parameter values in lantern
Ngalstyan4
force-pushed
the
narek/pgvector-compat
branch
from
0924865 to
e0066d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes latest LanternDB copatible with pgvector 0.4.4 as well as pgvector 0.5.0
When the newer pgvector is already installed, now we create a compatibility-mode
lantern_hnswaccess method in stead of thehnswdefaultThe PR also renames some of our internal C functions that would otherwise clash with homonymous pgvector functions