Cleanup and asserts #130
Merged
Cleanup and asserts #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
+ Coverage 83.57% 84.27% +0.69%
==========================================
Files 16 17 +1
Lines 1163 1170 +7
Branches 258 249 -9
==========================================
+ Hits 972 986 +14
+ Misses 81 79 -2
+ Partials 110 105 -5
|
Benchmarks
|
|
By this change, should we use |
Ngalstyan4
force-pushed
the
narek/cleanup_and_asserts
branch
from
c91f646 to
887e1c5
Compare
|
No, some errors are expected and we can actually trigger them in tests.
|
|
TODO: Add an invariant check to |
var77
approved these changes
Sep 10, 2023
Ngalstyan4
force-pushed
the
narek/cleanup_and_asserts
branch
2 times, most recently
from
c0fa46b to
725c1b3
Compare
dqii
reviewed
Sep 10, 2023
src/hooks/plan_tree_walker.c
Outdated
| @@ -55,7 +57,7 @@ bool plan_tree_walker(Plan *plan, bool (*walker_func)(Node *plan, void *context) | |||
| // Join nodes | |||
| case T_Join: | |||
| Join *join = (Join *)plan; | |||
| if(base_plan_walker(&(join->plan), walker_func, context)) return true; | |||
| if(base_plan_walker((Plan *)&(join->plan), walker_func, context)) return true; | |||
There was a problem hiding this comment.
I don't think this or the one below should be necessary, join->plan is always a plan.
There was a problem hiding this comment.
You are right. removed it.
dqii
approved these changes
Sep 10, 2023
Ngalstyan4
force-pushed
the
narek/cleanup_and_asserts
branch
from
e8c0651 to
6bbc630
Compare
Per the standard: https://port70.net/~nsz/c/c11/n1570.html#6.8.1 Labels must be followed by a statement. Switch 'case's are just labels. So, we cannot have a variable declaration right after a 'case'. We *can* have a code block however, which is what this PR does. It seems the newer compilers handle the case when a declaration comes after a switch 'case'. But my compiler (gcc 10.2) complained about it
Ngalstyan4
force-pushed
the
narek/cleanup_and_asserts
branch
from
fac194c to
5f01084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.