Add Mac builds into CI pipeline #143
Conversation
|
Can you install pgvector in mac as well so our pgvector tests also run? I think right now those tests will fail because of an innocuous reordering issue in the test. |
@Ngalstyan4 currently I do not run tests on mac as in CI it is collecting coverage information now and the postgres should be run in a custom way with gcov enabled. I should separate that part as well, so the tests will run on mac without coverage information. Should I implement it in this PR? |
scripts/get_arch_and_platform.sh
Outdated
| Linux*) PLATFORM=linux;; | ||
| Darwin*) PLATFORM=mac;; | ||
| CYGWIN*) PLATFORM=cygwin;; | ||
| MINGW*) PLATFORM=mingw;; |
There was a problem hiding this comment.
when do we expect cygwin, mingw cases to be hit?
There was a problem hiding this comment.
they seems to be some unix like shells for windows, but I didn't test them.
var77
force-pushed
the
feature/mac-build
branch
3 times, most recently
from
a2762f1 to
ed322f8
Compare
|
@Ngalstyan4 @dqii I did the requested changes and also added tests for mac os (with pgvector). There needed to do some modifications on pgvector test file to make it more consistent over the platforms. |
|
It still lgtm. Sorry, I merged Postgres 16 so there are a few conflicts |
No worries, I will fix them later today |
var77
force-pushed
the
feature/mac-build
branch
from
3d556a0 to
37c5623
Compare
Description
build.sh- this is common script for both linux and mocos platforms. This will be executed from the pipelinebuild-linux.sh- linux specific environment setup functionsbuild-mac.sh- macos specific environment setup functionsnow the universal archive will have the following structure
$arch/$platform/$pg_version/lantern.soThe command to get architecture changed from
dpkg --print-architecturetouname -m, so we will have the same output for both linux and macos. Previously thedpkgwas printingamd64anduname -mx86_64.Cleaned up the build scripts and action yaml files.
I will also open PR on
lantern_extrasto add macos support#7