Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create source code archive manually #173

Merged
merged 1 commit into from
Sep 24, 2023
Merged

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Sep 21, 2023

Currently on release pipeline the Source Code archive Github is creating automatically does not include the submodules in it, so basically if someone will download the source code archive and try to build from it one will get an error.
With this PR, we will create an archive of source code with all submodules manually and upload it to release artifacts under the name lantern-v$version-source.tar.gz

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.784 0.784 -
select bulk tps 144.527 169.174 +17.05%
select bulk latency (ms) 54.570 46.587 -14.63%
select bulk latency (stddev ms) 7.417 8.681 +17.04%
create latency (ms) 1741.155 1449.394 -16.76%
insert bulk tps 8.137 9.864 +21.22%
insert bulk latency (ms) 122.867 101.360 -17.50%
insert bulk latency (stddev ms) 5.116 3.292 -35.65%
disk usage (bytes) 6348800.000 6348800.000 -

@var77 var77 force-pushed the varik/full-source-archive branch from e69d757 to 1235b05 Compare September 22, 2023 11:15
@Ngalstyan4 Ngalstyan4 merged commit cc6af0a into main Sep 24, 2023
@Ngalstyan4 Ngalstyan4 deleted the varik/full-source-archive branch September 24, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants