Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc changes from several PRs (look at individual commits) #176

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Conversation

Ngalstyan4
Copy link
Contributor

Made small changes and stress-tested the PRs locally

@github-actions
Copy link

github-actions bot commented Sep 24, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.784 0.774 -1.28%
select bulk tps 164.285 163.450 -0.51%
select bulk latency (ms) 47.095 46.718 -0.80%
select bulk latency (stddev ms) 9.997 13.331 +33.35%
create latency (ms) 1495.074 1469.171 -1.73%
insert bulk tps 9.443 12.417 +31.50%
insert bulk latency (ms) 105.887 80.515 -23.96%
insert bulk latency (stddev ms) 3.466 2.031 -41.40%
disk usage (bytes) 6348800.000 6348800.000 -

using elog() directly has significant overhead, even when the level at which we elog is disabled.
This adds a simple wrapper around elog and only calls elog when we know we most likely want the printed message
@Ngalstyan4 Ngalstyan4 merged commit f329ce5 into main Sep 25, 2023
@Ngalstyan4 Ngalstyan4 deleted the main-dev branch September 25, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants