-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figuring out why tests fail on main #214
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
==========================================
+ Coverage 83.06% 83.17% +0.10%
==========================================
Files 18 18
Lines 1234 1236 +2
Branches 264 264
==========================================
+ Hits 1025 1028 +3
Misses 83 83
+ Partials 126 125 -1
|
That is strange, I had added a line to fetch from remote in python script before, but seems it's not helping here. I can test this in my fork later today and let you know |
@Ngalstyan4 in my fork here it is passing the tests in main |
var77
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CI runs fail once a PR is merged, even though all tests pass while the change is an open PR.
The culprit is the recently added version update script. It seems somehow repo tags exist while the CI/CD is running on a pr but the repo tags are missing once CI/CD is running on the merged commit on main.
This made me think that the checkout action by default does not pull tag info and this PR attempts to fix it.
@var77, Do you think this the issue? Do you think my changes would fix it?
Is there a way to test this before we merge?