Implement failure points #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds API to trigger execution of C code from SQL to test corner cases. `test/sql/hnsw_failure_point.sql` has an example of how to trigger a process crash using failure points and how to see that a space leak happens if a crash happens after a block is allocated, but before a record for the block is added to the index during blockmaps creation.
Ngalstyan4
reviewed
Oct 27, 2023
src/hnsw/failure_point.c
Outdated
| *state = (struct failure_point_state){ | ||
| .enabled = true, | ||
| .func = func, | ||
| .name = name, |
There was a problem hiding this comment.
Do name and func live long enough for when it is used from state?
Both go out of scope and are freed as soon as the SQL function returns. It is allocated by the function context.
so, at that point the global state.name is dangling.
If this is the case, you should probably copy the strings. We do not care about performance for these, it should be fine
If you need the name after the
There was a problem hiding this comment.
Good catch. Done.
I had a choice between using malloc() directly, using char func[0x100]; for the state->func and using a custom PostgreSQL allocator for this file. char func[0x100]; won.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds API to trigger execution of C code from SQL to test corner cases.
test/sql/hnsw_failure_point.sqlhas an example of how to trigger a process crash using failure points and how to see that a space leak happens if a crash happens after a block is allocated, but before a record for the block is added to the index during blockmaps creation.