Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing handling for operator usage in Materialized queries #228

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

Ngalstyan4
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 commented Nov 25, 2023

Fixes #227

Copy link

github-actions bot commented Nov 25, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.784 0.778 -0.77%
select bulk tps 477.403 498.118 +4.34%
select bulk latency (ms) 16.097 15.843 -1.58%
select bulk latency (stddev ms) 3.106 1.360 -56.21%
create latency (ms) 1225.192 1227.194 +0.16%
insert bulk tps 11.208 11.058 -1.34%
insert bulk latency (ms) 89.212 90.427 +1.36%
insert bulk latency (stddev ms) 3.380 3.737 +10.56%
disk usage (bytes) 6348800.000 6348800.000 -

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #228 (673f683) into main (1c2ff53) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   78.14%   78.20%   +0.05%     
==========================================
  Files          23       23              
  Lines        1643     1647       +4     
  Branches      404      405       +1     
==========================================
+ Hits         1284     1288       +4     
- Misses        177      178       +1     
+ Partials      182      181       -1     
Files Coverage Δ
src/hooks/plan_tree_walker.c 66.66% <50.00%> (-0.84%) ⬇️

... and 1 file with indirect coverage changes

@Ngalstyan4 Ngalstyan4 requested a review from dqii November 25, 2023 05:53
@Ngalstyan4 Ngalstyan4 force-pushed the narek/operator-cross-join branch 3 times, most recently from 2391a49 to e7895a6 Compare November 25, 2023 21:34
- Add comment about default

- Add success case and a more complex error case
@Ngalstyan4 Ngalstyan4 force-pushed the narek/operator-cross-join branch from e7895a6 to 673f683 Compare November 25, 2023 21:50
@Ngalstyan4 Ngalstyan4 merged commit 9856abf into main Nov 25, 2023
@Ngalstyan4 Ngalstyan4 deleted the narek/operator-cross-join branch November 25, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Distance operator <-> wrongly used in CROSS-JOIN queries without a vector index
2 participants