Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerfile with postgres debug build #233

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Dec 1, 2023

This dockerfile can help to better debug the database crashes as it has postgres built with debug symbols.
In the top of the Dockerfile you can find the instructions on how to build and run the image to use gdb

Copy link

github-actions bot commented Dec 1, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.790 0.730 -7.59%
select bulk tps 474.798 469.113 -1.20%
select bulk latency (ms) 15.563 15.777 +1.38%
select bulk latency (stddev ms) 3.889 4.121 +5.97%
create latency (ms) 1192.118 1191.676 -0.04%
insert bulk tps 11.178 11.557 +3.39%
insert bulk latency (ms) 89.451 86.516 -3.28%
insert bulk latency (stddev ms) 3.011 3.598 +19.50%
disk usage (bytes) 6348800.000 6348800.000 -

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #233 (011a8ca) into main (1a6ba51) will decrease coverage by 0.35%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   78.20%   77.85%   -0.35%     
==========================================
  Files          23       23              
  Lines        1647     1653       +6     
  Branches      405      410       +5     
==========================================
- Hits         1288     1287       -1     
- Misses        178      185       +7     
  Partials      181      181              

see 5 files with indirect coverage changes

@var77 var77 requested a review from Ngalstyan4 December 3, 2023 12:38
@Ngalstyan4
Copy link
Contributor

Are there any downsides to using this image?
Should we just update Dockerfile.dev with this, so in development we always get full stack traces into postgres.

@var77
Copy link
Collaborator Author

var77 commented Dec 5, 2023

Are there any downsides to using this image? Should we just update Dockerfile.dev with this, so in development we always get full stack traces into postgres.

Yes actually it is fine, I have changed it to use the debug version

@var77 var77 merged commit 37a8519 into main Dec 6, 2023
@var77 var77 deleted the varik/postgres-debug-dockerfile branch December 6, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants