Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory context for List node allocation in op_rewrite.c #234

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Dec 1, 2023

No description provided.

Copy link

github-actions bot commented Dec 1, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.728 0.734 +0.82%
select bulk tps 507.666 475.538 -6.33%
select bulk latency (ms) 15.486 16.118 +4.08%
select bulk latency (stddev ms) 0.933 3.540 +279.42%
create latency (ms) 1204.685 1195.529 -0.76%
insert bulk tps 11.539 11.413 -1.09%
insert bulk latency (ms) 86.656 87.613 +1.10%
insert bulk latency (stddev ms) 3.368 2.878 -14.55%
disk usage (bytes) 6348800.000 6348800.000 -

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Merging #234 (679c4fd) into main (1a6ba51) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #234   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files          23       23           
  Lines        1647     1647           
  Branches      405      405           
=======================================
  Hits         1288     1288           
  Misses        178      178           
  Partials      181      181           
Files Coverage Δ
src/hooks/op_rewrite.c 83.94% <100.00%> (ø)

@Ngalstyan4 Ngalstyan4 merged commit e940115 into main Dec 4, 2023
@Ngalstyan4 Ngalstyan4 deleted the varik/fix-op-rewrite-mem-bug-2 branch December 4, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants