Narek/release0.0.8 #235
Merged
Narek/release0.0.8 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 78.20% 77.85% -0.35%
==========================================
Files 23 23
Lines 1647 1653 +6
Branches 405 410 +5
==========================================
- Hits 1288 1287 -1
- Misses 178 185 +7
Partials 181 181
|
Ngalstyan4
force-pushed
the
narek/release0.0.8
branch
4 times, most recently
from
5a92483 to
3fffb3e
Compare
So far update scripts only made changes in the SQL layer This works so long as the data structures in the old Lantern and new lantern versions are compatible. This is not the case when we change storage format, or header page, for example. To mitigate this,we can either: 1. Write binary level update routines that patch necessary DB and lanter index pages 2. Recreate all binary data structures by rerunning equivalent SQL-level statements This commit implements the second approach. We can stil have one-off cases of the first. But, whenever something in the binary formats of lantern chagnes and a specific migration script (1) does not exist, the 2nd approach must appropriately be integrated, as demonstrated in this commit
Running it has no benefit as it always runs on a single version of the extension - the test suit drops and re create the extension so the fact that we just ran an update does not make a difference we can add this back when we actually restructure the tests so CREATE routines can run on older version and the rest - on newer updated version
Now that we preload lantern shared library, our hooks see more statements than before. With this we ignore create/update statements in hooks because 1) they are irrelevant 2) our hooks assume DB state that is not satisfied when these statements are running Warn when lantern is preloaded. Note: These checks were added when considering a move to preloaded lantern. We ultimately abandoned the move, so, the code is only relevant in self-hosting if one decides to preload lantern.
Ngalstyan4
force-pushed
the
narek/release0.0.8
branch
from
3fffb3e to
ee52249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.