-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C client tests to catch op_rewriting segfault #238
Conversation
Benchmarks
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 77.85% 77.85%
=======================================
Files 23 23
Lines 1653 1653
Branches 410 410
=======================================
Hits 1287 1287
Misses 185 185
Partials 181 181
|
9e2690d
to
3862773
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. feel free to merge!
Added tests with C libpq client to catch the segfault happening on operator rewrite hook.
To add new tests you need to do the following:
test/c/
test/runner.c
test_cases[]
inrunner.c