Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C client tests to catch op_rewriting segfault #238

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Dec 3, 2023

Added tests with C libpq client to catch the segfault happening on operator rewrite hook.

To add new tests you need to do the following:

  1. Create test file under test/c/
  2. Include test file in test/runner.c
  3. Add test case to test_cases[] in runner.c

@var77 var77 requested a review from Ngalstyan4 December 3, 2023 16:44
Copy link

github-actions bot commented Dec 3, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.790 0.744 -5.82%
select bulk tps 474.798 508.593 +7.12%
select bulk latency (ms) 15.563 15.582 +0.12%
select bulk latency (stddev ms) 3.889 1.119 -71.23%
create latency (ms) 1192.118 1191.062 -0.09%
insert bulk tps 11.178 11.470 +2.61%
insert bulk latency (ms) 89.451 87.177 -2.54%
insert bulk latency (stddev ms) 3.011 1.535 -49.02%
disk usage (bytes) 6348800.000 6348800.000 -

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #238 (0ebc038) into main (96f50b3) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   77.85%   77.85%           
=======================================
  Files          23       23           
  Lines        1653     1653           
  Branches      410      410           
=======================================
  Hits         1287     1287           
  Misses        185      185           
  Partials      181      181           
Files Coverage Δ
src/hooks/op_rewrite.c 83.21% <100.00%> (ø)

@var77 var77 force-pushed the varik/c-client-tests branch from 9e2690d to 3862773 Compare December 4, 2023 07:36
@var77 var77 changed the title Add test C client tests to catch op_rewriting segfault Add C client tests to catch op_rewriting segfault Dec 4, 2023
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@Ngalstyan4 Ngalstyan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. feel free to merge!

@var77 var77 merged commit 78f0ebd into main Dec 6, 2023
@var77 var77 deleted the varik/c-client-tests branch December 6, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants