-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to disable operator rewriting hooks and make pgvector compatible #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
==========================================
- Coverage 77.85% 77.68% -0.18%
==========================================
Files 23 23
Lines 1653 1685 +32
Branches 410 415 +5
==========================================
+ Hits 1287 1309 +22
- Misses 185 191 +6
- Partials 181 185 +4
|
5eb3afb
to
65db102
Compare
Ngalstyan4
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! This was quick:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lantern.pgvector_compat
variable which when set toTRUE
will disable the<->
operator rewriting hooks and enable<=>
and<+>
operator usages for cosine and hamming distances.<=>
) and hamming (<+>
) distances with corresponding operator classes. These operators will only work iflantern.pgvector_compat=TRUE
lantern.pgvector_compat=TRUE
, so we will be sure that no operator rewriting is happening