WAL/blockmaps: continue blockmaps initialization after failure #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var77
force-pushed
the
varik/wal-blockmaps
branch
from
5091161 to
dfac872
Compare
Benchmarks
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 77.68% 78.17% +0.49%
==========================================
Files 23 23
Lines 1685 1778 +93
Branches 415 449 +34
==========================================
+ Hits 1309 1390 +81
- Misses 191 194 +3
- Partials 185 194 +9
|
var77
changed the title
ContinueBlockMapGroupInitialization() description has all the details about how it's done and how different kinds of failures are handled.
…endBufferedRelTo() for PostgreSQL < 16
…erPage.blockmap_groups[]
This reverts commit 99a9f2f.
This patch adds API to trigger execution of C code from SQL to test corner cases. `test/sql/hnsw_failure_point.sql` has an example of how to trigger a process crash using failure points and how to see that a space leak happens if a crash happens after a block is allocated, but before a record for the block is added to the index during blockmaps creation.
var77
force-pushed
the
varik/wal-blockmaps
branch
from
fa2c14b to
4c280e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from PR#211 to rebase with main.