Fix l2 operator bug when used with int arrays #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need properly copy and cast array elements when int array is bassed and we need floats.
Previusly we were interpreting float* array as an int32* array when calculating distances.
I think this issue does not exist when creating an index since there casts happen before. I also added a test to demonstrate this (was it already tested elsewhere and I missed it?). If you can think of other edge cases, let me know here.
The added tests check operator output when used directly. Below is the diff if I ran the same tests without the bugfix: