Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narek/handle deletes #317

Merged
merged 5 commits into from
May 4, 2024
Merged

Narek/handle deletes #317

merged 5 commits into from
May 4, 2024

Conversation

Ngalstyan4
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

7 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@codecov Codecov
Copy link

codecov bot commented May 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 89.47368% with 4 lines in your changes are missing coverage. Please review.

Files Patch % Lines
src/hnsw/delete.c 89.65% 0 Missing and 3 partials ⚠️
src/hnsw/scan.c 83.33% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

11 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024 •
edited
Loading

Benchmarks

metric old new pct change
recall (after create) 0.948 0.955 +0.74%
recall (after insert) 0.000 0.000 -
select tps 19529.661 22371.365 +14.55%
select bulk(100) tps 33.739 34.950 +3.59%
select latency (ms) 0.852 ± 2.074𝜎 0.820 ± 1.630𝜎 -3.76%
select bulk(100) latency (ms) 842.798 ± 160.926𝜎 835.402 ± 166.157𝜎 -0.88%
create latency (ms) 366305.604 369841.874 +0.97%
insert tps 483.653 493.207 +1.98%
insert bulk(100) tps 4.962 5.174 +4.27%
insert latency (ms) 65.384 ± 18.408𝜎 63.977 ± 17.833𝜎 -2.15%
insert bulk(100) latency (ms) 6310.746 ± 201.929𝜎 6006.067 ± 213.679𝜎 -4.83%
disk usage (bytes) 8196194304.000 8196194304.000 -

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

5 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 force-pushed the narek/handle-deletes branch from 99f0fe8 to 54bb46e Compare May 4, 2024 01:19
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

9 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 force-pushed the narek/handle-deletes branch from 54bb46e to dfe48c2 Compare May 4, 2024 01:31
Ngalstyan4 added 4 commits May 4, 2024 01:47
@Ngalstyan4
Properly mark deleted items as such in the index
02b7e33 
This is necessary to make sure that we do not return irrelevant
and wrong results when eventually postgres reuses tids
@Ngalstyan4
Remove outdated branch checks in update script
c4e56bd 
- Updates for mentioned versions are archived, so the checks are
unnecessary
- There was a todo to revert current version mismatch warning into an
  error. As we move to support live upgrades, it is crucial to
maintain cross-version binary compatibility as that greatly simplifies
the update process. So, we will not be moving away from the warning
approach
@Ngalstyan4
Add replication/WAL test
cf9d39b 
add requirements txt
@Ngalstyan4
Release 0.2.7
01de4d5
@Ngalstyan4 Ngalstyan4 force-pushed the narek/handle-deletes branch from dfe48c2 to 01de4d5 Compare May 4, 2024 01:47
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

9 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

The update tests on Linux failed. Please check the logs for more details.

@Ngalstyan4 Ngalstyan4 merged commit cd7f187 into main May 4, 2024
42 of 45 checks passed
@Ngalstyan4 Ngalstyan4 deleted the narek/handle-deletes branch May 4, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ngalstyan4