[5.5] Ensure Router returns a JsonResponse for Arrayable, Jsonable (...) #17875
Conversation
|
What is the actual benefit of this? |
|
They are many @taylorotwell , in a normal Response, you cannot get and set the encoding option, you cannot set the callback either. This PR solves that. |
|
I really feel like instead of all this header business you should just check for Arrayable or Jsonable in the |
lucasmichot
changed the title
|
@taylorotwell , the check is now done in the Router; see a7edae8. |
|
👎 This forces people to use json at the router level. |
|
What if they wanted a streamed json resource too? |
|
@GrahamCampbell I don't follow. We were returning |
src/Illuminate/Routing/Router.php
Outdated
| */ | ||
| public function prepareResponse($request, $response) | ||
| { | ||
| if ($response instanceof PsrResponseInterface) { | ||
| $response = (new HttpFoundationFactory)->createResponse($response); | ||
| } elseif (! $response instanceof SymfonyResponse) { | ||
| $response = new Response($response); | ||
| if ($response instanceof Arrayable || |
|
Ah, right, probably fine then. |
For now only a normal
Response, mimicing aJsonResponseis returned; this enforces aJsonResponseto be returned.A much more performant way to achieve #17869 /cc @taylorotwell