Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.5] make fluent Route::middleware work with variadic arguments #21930

Merged
merged 2 commits into from
Nov 3, 2017

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Nov 2, 2017

Currently:

Route::get('two', function () {
            return 'Hello World';
})->middleware(Middleware::class, Middleware2::class);

Middleware2 will run, but if you do this it won't:

Route::middleware(Middleware::class, Middleware2::class)
    ->get('one', function () {
                return 'Hello World';
});
``

This PR fixes that.

@taylorotwell taylorotwell merged commit 0104ee7 into laravel:5.5 Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants