[5.5] Make assertJsonCount able to use nested keys

[crissi]

Enhanced testing helper with assertJsonCount to be able to use nested keys for checking count more than just one level deep.

Added some tests that illustrate it pretty well.

[christophrumpel]

Hey @crissi ,

I got a question regarding this test:

$response->assertJsonCount(2, 'baz.*.bar');

What is the exact purpose of it? In baz we have two items and each of them has a key bar with two items. So should it be about the first one or about both?

I also think it currently only checks the items count within baz. Because when I test it like this:

$response->assertJsonCount(2, 'baz.*.1234');

Then the test still works because data_get($this->json(), $key) still returns an array with two items, but the items are null.

Am I getting something wrong here?

[crissi]

I will look into it Få Outlook til iOS<https://aka.ms/o0ukef>

…

________________________________ From: Christoph Rumpel <[email protected]> Sent: Friday, January 26, 2018 1:44:29 PM To: laravel/framework Cc: Christian; Mention Subject: Re: [laravel/framework] [5.5] Make assertJsonCount able to use nested keys (#22740) Hey @crissi<https://github.com/crissi> , I got a question regarding this test: $response->assertJsonCount(2, 'baz.*.bar'); What is the exact purpose of it? In baz we have two items and each of them has a key bar with two items. So should it be about the first one or about both? I also think it currently only checks the items count within baz. Because when I test it like this: $response->assertJsonCount(2, 'baz.*.1234'); Then the test still works. Am I getting something wrong here? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22740 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AC7x4nTDc0TREyTha7m3VoAPht4myKd5ks5tOcitgaJpZM4RbE6e>.

[crissi]

You are right it I not meant to be used with *. I wil fix the tests