[5.6] Revert #24000 #24283
Closed
[5.6] Revert #24000 #24283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of reverting the entire PR, could you just revert the changes to Builder.php? It sounds reasonable to keep the test to ensure everything still works. |
|
The test doesn't work anymore because it only tested this specific workaround. |
|
Unless there is a problem with this remaining I will just leave it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24000 fixed a bindings problem with
$withCountand nestedwhere()constraints (#23957).Since #24240 solves the underlying problem in a more general way, the fix from #24000 is not required anymore:
Builder::where()now usesModel::newModelQuery()which creates a query without$withCount.