[7.x] Rename CastsAttributes contract methods

[antonkomarev]

This PR is proposal to rename methods introduced in PR #31035 by @taylorotwell

From my point of view get & set methods are too common and doesn't expose their meaning enough.

This question was raised many times before in different discussion threads. Here is one of the explanations from @sisve #30958 (comment)

I propose to rename them to fromDatabase and toDatabase respectively.

[GrahamCampbell]

I think get and set are super clear already, because they are totally consistent with the existing terminology. Get is decode and set is encode.

[taylorotwell]

fromDatabase and toDatabase I found too confusing while prototyping the feature and using it myself. getFooAttribute and setFooAttribute are already how mutators are defined so get and set is consistent with that terminology and is basically impossible to confuse.

[taylorotwell]

As a follow up, it's very unlikely I'll be considering any "bike shedding" type changes (renaming, etc.) unless there is a VERY good reason to do so. I feel like my PR a few years ago got derailed on those types of things and I'm not going to let that happen again.

[andrey-helldar]

@taylorotwell, as they say in our country - "your own shit does not smell" 😉

PS: this expression is by no means used to insult anything. It is used in cases where someone intentionally denies the existence of a better version of something.

[andrey-helldar]

unless there is a VERY good reason to do so

In other words, there are 100,500 reasons why this will not be done :)

Great strategy! 👏👏👏

(sarcasm)