Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.x] Application@handle() meets Symfony 6's updated HttpKernelInterface #38413

Merged
merged 1 commit into from
Aug 17, 2021
Merged

[9.x] Application@handle() meets Symfony 6's updated HttpKernelInterface #38413

merged 1 commit into from
Aug 17, 2021

Conversation

derekmd
Copy link
Contributor

@derekmd derekmd commented Aug 16, 2021

More Symfony 6 type-checking whack-a-mole.

#38376 passed green but Symfony's 6.x dev branch introduced another breaking change within 3 hours.

HttpKernelInterface::MASTER_REQUEST has also been deprecated for HttpKernelInterface::MAIN_REQUEST.

@derekmd
Make Application@handle() meet Symfony 6's updated interface
e893710 
Add return type. This is a great use of our time.
@derekmd derekmd marked this pull request as ready for review August 16, 2021 22:30
@driesvints
Copy link
Member

Thanks @derekmd. Saves me the time for doing it :)

@taylorotwell taylorotwell merged commit edbbcdb into laravel:master Aug 17, 2021
@driesvints driesvints mentioned this pull request Aug 17, 2021
Closed
@derekmd derekmd deleted the symfony6-fixes branch August 17, 2021 15:42
@felixdorn felixdorn mentioned this pull request Sep 19, 2021
Closed
@otilor otilor mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derekmd @driesvints @taylorotwell