Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Declare that abort(), dd() and kill() never return #39108

Merged
merged 6 commits into from
Oct 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Database/Query/Builder.php
Original file line number Diff line number Diff line change
Expand Up @@ -3402,7 +3402,7 @@ public function dump()
/**
* Die and dump the current SQL and bindings.
*
* @return void
* @return never
*/
public function dd()
{
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Application.php
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ public function isDownForMaintenance()
* @param int $code
* @param string $message
* @param array $headers
* @return void
* @return never
*
* @throws \Symfony\Component\HttpKernel\Exception\HttpException
* @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/helpers.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
* @param \Symfony\Component\HttpFoundation\Response|\Illuminate\Contracts\Support\Responsable|int $code
* @param string $message
* @param array $headers
* @return void
* @return never
*
* @throws \Symfony\Component\HttpKernel\Exception\HttpException
* @throws \Symfony\Component\HttpKernel\Exception\NotFoundHttpException
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Queue/Worker.php
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ public function stop($status = 0)
* Kill the process.
*
* @param int $status
* @return void
* @return never
*/
public function kill($status = 0)
{
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Support/Facades/App.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* @method static string storagePath(string $path = '')
* @method static string version()
* @method static string|bool environment(string|array ...$environments)
* @method static void abort(int $code, string $message = '', array $headers = [])
* @method static never abort(int $code, string $message = '', array $headers = [])
* @method static void boot()
* @method static void booted(callable $callback)
* @method static void booting(callable $callback)
Expand Down
2 changes: 1 addition & 1 deletion src/Illuminate/Support/Stringable.php
Original file line number Diff line number Diff line change
Expand Up @@ -789,7 +789,7 @@ public function dump()
/**
* Dump the string and end the script.
*
* @return void
* @return never
*/
public function dd()
{
Expand Down