[8.x] Revert "[8.x] Add nested relationships to whereRelation function (#39064)" #39130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are unrelated to this PR. |
driesvints
approved these changes
Oct 7, 2021
driesvints
changed the title
|
Thanks @JurianArie. I've restarted the build for you. |
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 7, 2021
laravel#39064)" (laravel#39130) * Revert "[8.x] Add nested relationships to whereRelation function (laravel#39064)" This reverts commit bc92a96. * Add tests for nested whereRelation queries
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
laravel#39064)" (laravel#39130) * Revert "[8.x] Add nested relationships to whereRelation function (laravel#39064)" This reverts commit bc92a96. * Add tests for nested whereRelation queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests reverts #39064 and adds tests to prove that whereRelation already worked with nested relationships.