[8.x] Return Command::SUCCESS enum instead of 0 for clarity to newer devs #39154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change was rejected in a PR from July. #38151 |
Interesting, I wonder what the reason is. I'm guess because there is already return 0 precedent set in other commands, but doing this for the custom command stub feels like a good idea. I've had even more seasoned devs ask this question or replace it with return true/false, etc. Just think it would be a nice change. |
chu121su12
pushed a commit
to chu121su12/framework
that referenced
this pull request
Oct 9, 2021
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This question seems to come up with newer devs and I saw this suggestion recently which I think could be useful as a default for the command stub. Swapping the exit status of 0 for the actual command status enum which makes it a bit more clear to a new dev what it actually signifies.