Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.x] Restore the ability to choose a database engine during the installation procedure #406

Closed
wants to merge 1 commit into from

Conversation

happytodev
Copy link

@happytodev happytodev commented Feb 28, 2025

This PR brings a fix to the #404 issue.

Maybe I'm wrong, but the line removed restores the possibility to choose a database engine during installation procedure.

Tell me if something is missing.

@happytodev happytodev changed the title Restore the ability to choose a database engine during the installation procedure [12.x] Restore the ability to choose a database engine during the installation procedure Feb 28, 2025
@MrYamous
Copy link

MrYamous commented Mar 1, 2025

I dont know if forcing migrate to false should stay too. Regarding to comment, I think this is related to sqlite only

@taylorotwell
Copy link
Member

I personally want things to be as quick as possible for starter kits so prefer to just ship it with SQLite as the default so it's ready to go with no more choices.

@happytodev
Copy link
Author

I personally want things to be as quick as possible for starter kits so prefer to just ship it with SQLite as the default so it's ready to go with no more choices.

I fully understand your point of view, but I think user first and personally I prefer to have the choice of shipping fast by choosing the right database engine directly during installation instead of changing it after installation.

But you're the boss, boss 😉

@MrYamous
Copy link

MrYamous commented Mar 5, 2025

The choice is given but ignored. I still believe this behavior is misleading.
Let's remove the database option then ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants