-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.x] Support Meilisearch index settings #669
Conversation
@mmachatschek I'd appreciate a review here if you're up for it : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me 👍 I'm just concerned about one change:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@driesvints this is a nice addition. thats basically the same code that I use in my environment. I didn't test your code but it looks rock solid 👍
Thanks! |
This is for everyone who is trying to add Meilisearch settings with @driesvints comment: The settings key is renamed to Updated version:
|
This PR adds support for Meilisearch's index settings:
https://docs.meilisearch.com/learn/configuration/settings.html
https://docs.meilisearch.com/reference/api/settings.html
Through a new
settings
key on thescout.meilisearch
config option, users will be able to define all the settings they need for their model indexes. These settings will be synced when the index is manually created through thescout:index
commandor whenever models get updated through the engineor when they use the newscout:sync-settings
command.