Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lint check to ci/cd #1272

Closed
wants to merge 1 commit into from
Closed

Add Lint check to ci/cd #1272

wants to merge 1 commit into from

Conversation

Ankush-lastmile
Copy link
Member

Add Lint check to ci/cd

@Ankush-lastmile Ankush-lastmile force-pushed the pr1272 branch 4 times, most recently from 13db870 to 2d7ee96 Compare February 20, 2024 23:54
Copy link
Member

@rholinshead rholinshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just running prettier, not actually linting, right? I would expect lint with yarn:

      - name: Lint
        run: |
          yarn lint

@Ankush-lastmile
Copy link
Member Author

This is just running prettier, not actually linting, right? I would expect lint with yarn:

Yep, was just playing around with the github action from the marketplaces to figure out how it works. Its great and its extensible enough to be used with python and typescript. Running the python linter bubbles up 150+ exceptions 😅

@Ankush-lastmile
Copy link
Member Author

Ankush-lastmile commented Feb 21, 2024

This is just running prettier, not actually linting, right? I would expect lint with yarn:

I was trying to run linting with prettier rules, not sure if that should be done in addition to yarn lint or if its not needed to begin with

@Ankush-lastmile
Copy link
Member Author

closing for now, will revisit later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants