clevis-luks-bind: Fix error with password of spaces #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/luks/clevis-luks-bind
Outdated
| @@ -98,8 +98,8 @@ fi | |||
| existing_key= | |||
| keyfile= | |||
| case "${KEY}" in | |||
| "") read -r -s -p "Enter existing LUKS password: " existing_key; echo >&2;; | |||
| -) read -r -s -p "" existing_key | |||
| "") echo -n "Enter existing LUKS password: "; existing_key=$(head -1); echo >&2;; | |||
There was a problem hiding this comment.
Something bad with this fix is that the password will be displayed as it is being typed. Perhaps a better way to fix this would be to clear IFS? Something like the following:
IFS= read -r -s -p "Enter existing LUKS password: " existing_key; echo >&2;;
There was a problem hiding this comment.
Yes, you're right. This is a better solution. I have updated my code. Thank you!
This fixes the problem with passwords that contain spaces at beginning or ending. Such a password will make the existing_key variable has an incorrect key and result into a "No key available with this passphrase.` or "Nothing to read on input." error.
sergio-correia
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem with passwords that contain spaces at beginning or ending. Such a password will make the
existing_keyvariable has an incorrect key and result into a "No key available with this passphrase.` or "Nothing to read on input." error.