luks: replace seq with bash's builtin sequence expression
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the same result without the added dep. Hit this in FCOS where we don't currently ship `seq` in the initramfs (normally, the clevis dracut module should've installed it if it requires it). We could do that of course, but it's even better if we can avoid it entirely.
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Feb 23, 2021
The dracut module from the latest Clevis v16 release has an undeclared dependency on `seq`. There's a patch to fix that upstream: latchset/clevis#295 But for now, let's just pin to the previous release. This will unblock lockfile bumps.
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Feb 23, 2021
The dracut module from the latest Clevis v16 release has an undeclared dependency on `seq`. There's a patch to fix that upstream: latchset/clevis#295 But for now, let's just pin to the previous release. This will unblock lockfile bumps.
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Feb 23, 2021
The dracut module from the latest Clevis v16 release has an undeclared dependency on `seq`. There's a patch to fix that upstream: latchset/clevis#295 But for now, let's just pin to the previous release. This will unblock lockfile bumps. (cherry picked from commit 03bf486)
sergio-correia
approved these changes
Feb 24, 2021
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Mar 9, 2021
Previously we pinned clevis to v15 in order to work around latchset/clevis#295. But overrides are not set up in the tagger for mechanical streams, so we can't easily pin in `branched` and `rawhide`. Let's just unpin and temporarily ship `seq` ourselves to work around this. Put that temporary hack in `40ignition-ostree` since that's the closest module conceptually to clevis.
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Mar 9, 2021
Previously we pinned clevis to v15 in order to work around latchset/clevis#295. But overrides are not set up in the tagger for mechanical streams, so we can't easily pin in `branched` and `rawhide`. Let's just unpin and temporarily ship `seq` ourselves to work around this. Put that temporary hack in `40ignition-ostree` since that's the closest module conceptually to clevis.
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Mar 9, 2021
Previously we pinned clevis to v15 in order to work around latchset/clevis#295. But overrides are not set up in the tagger for mechanical streams, so we can't easily pin in `branched` and `rawhide`. Let's just unpin and temporarily ship `seq` ourselves to work around this. Put that temporary hack in `40ignition-ostree` since that's the closest module conceptually to clevis.
jlebon
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Mar 15, 2021
Previously we pinned clevis to v15 in order to work around latchset/clevis#295. But overrides are not set up in the tagger for mechanical streams, so we can't easily pin in `branched` and `rawhide`. Let's just unpin and temporarily ship `seq` ourselves to work around this. Put that temporary hack in `40ignition-ostree` since that's the closest module conceptually to clevis. (cherry picked from commit ad5eb32)
|
Does this remove agnostic shell use? (dash/zsh/fish) |
dustymabe
added a commit
to dustymabe/fedora-coreos-config
that referenced
this pull request
Apr 30, 2021
This was added in ad5eb32 for clevis, but clevis has been changed to no longer need `seq` [1] so we can drop it. [1] latchset/clevis#295
dustymabe
added a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Apr 30, 2021
This was added in ad5eb32 for clevis, but clevis has been changed to no longer need `seq` [1] so we can drop it. [1] latchset/clevis#295
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
The dracut module from the latest Clevis v16 release has an undeclared dependency on `seq`. There's a patch to fix that upstream: latchset/clevis#295 But for now, let's just pin to the previous release. This will unblock lockfile bumps.
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Previously we pinned clevis to v15 in order to work around latchset/clevis#295. But overrides are not set up in the tagger for mechanical streams, so we can't easily pin in `branched` and `rawhide`. Let's just unpin and temporarily ship `seq` ourselves to work around this. Put that temporary hack in `40ignition-ostree` since that's the closest module conceptually to clevis.
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
The dracut module from the latest Clevis v16 release has an undeclared dependency on `seq`. There's a patch to fix that upstream: latchset/clevis#295 But for now, let's just pin to the previous release. This will unblock lockfile bumps.
HuijingHei
pushed a commit
to HuijingHei/fedora-coreos-config
that referenced
this pull request
Oct 10, 2023
Previously we pinned clevis to v15 in order to work around latchset/clevis#295. But overrides are not set up in the tagger for mechanical streams, so we can't easily pin in `branched` and `rawhide`. Let's just unpin and temporarily ship `seq` ourselves to work around this. Put that temporary hack in `40ignition-ostree` since that's the closest module conceptually to clevis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the same result without the added dep.
Hit this in FCOS where we don't currently ship
seqin the initramfs(normally, the clevis dracut module should've installed it if it
requires it). We could do that of course, but it's even better if we can
avoid it entirely.