Fix logical error in p11prov_rsakm_secbits #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, just needs commit sign-off-by line. |
The branching in p11prov_rsakm_secbits() has missed the 2048 value because of < 2048 and > 2048 checks. Fix the off-by-one check. Signed-off-by: Ondřej Surý <[email protected]>
oerdnj
force-pushed
the
fix-missing-value-in-a-branch
branch
from
7b65aa9 to
b5b29d0
Compare
Done, and it will be soon updated in all PRs. |
Excellent! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branching in p11prov_rsakm_secbits() has missed the 2048 value
because of < 2048 and > 2048 checks. Fix the off-by-one check.