Detect if token is write protected #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In which case return early and do not even try to login and go through operations that will fail. Signed-off-by: Simo Sorce <[email protected]>
|
@rjrelyea can you review? |
beldmit
approved these changes
Jan 5, 2023
|
@beldmit NSS softokn by default always exposes two slots and one is always write protected because it is not intended for storing data, so this is implicitly tested in CI. |
|
Yes, it looks good. This will also return read only in softoken if the the DB's are openned read only. Also smart card are often read only as they are provisioned outside of PKCS #11, so this is a good general solution. |
|
Thanks Bob |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In which case return early and do not even try to login and go through operations that will fail.