Add missing single-line braces using clang-tidy #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerdnj
force-pushed
the
add-missing-braces
branch
4 times, most recently
from
31e2056 to
3db4468
Compare
|
Can we merge the github actions for style check and tidy into one? |
simo5
reviewed
Jul 25, 2022
I guess, let me check. |
Using the clang-tidy's readability-braces-around-statements check, add missing braces around single-line statements. Signed-off-by: Ondřej Surý <[email protected]>
Add a basic GitHub Action to run clang-tidy with (so-far) only the check for the single-line braces enabled. More checks can be enabled later. Signed-off-by: Ondřej Surý <[email protected]>
oerdnj
force-pushed
the
add-missing-braces
branch
from
3db4468 to
300ba81
Compare
Ok, should be done. I'll push one more time with code that's unformatted to check if it does what it should. |
|
Looks good |
oerdnj
force-pushed
the
add-missing-braces
branch
from
d713199 to
300ba81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the clang-format doesn't have (yet) the capability to add braces around single read statements, clang-tidy needs to be used for this.