Set the value for CRYPTO_LIBS flag correctly #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently value for CRYPTO_LIBS has a bogus value.
PKG_CHECK_MODULES automatically creates _LIBS flag (See ). This was missing for [CRYPTO].
Due do this, rpmlint -i test on the rpm had 106 warning like:
pkcs11-provider.x86_64: W: undefined-non-weak-symbol /usr/lib64/ossl-modules/pkcs11.so ASN1_INTEGER_it»·(/usr/lib64/ossl-modules/pkcs11.so)
And libcrypto.so was missing in Requires
Requires
pkcs11-provider (rpmlib, GLIBC filtered):
libc.so.6()(64bit)
rtld(GNU_HASH)
This PR fixes the above issues.
[root@vm-10-0-187-0 packaging]# ldd /usr/lib64/ossl-modules/pkcs11.so
linux-vdso.so.1 (0x00007fffecf29000)
libcrypto.so.3 => /lib64/libcrypto.so.3 (0x00007f109b000000)
libc.so.6 => /lib64/libc.so.6 (0x00007f109ac00000)
libz.so.1 => /lib64/libz.so.1 (0x00007f109b5f6000)
/lib64/ld-linux-x86-64.so.2 (0x00007f109b65f000)
[root@vm-10-0-187-0 packaging]# rpmlint -i pkcs11-provider
======================================================================================================== rpmlint session starts =======================================================================================================
rpmlint: 2.4.0
configuration:
/usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 1
========================================================================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s