Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uneven Behavior of List Elements #2614

Closed
mhimanshu712 opened this issue Feb 29, 2020 · 9 comments · Fixed by #2772
Closed

Uneven Behavior of List Elements #2614

mhimanshu712 opened this issue Feb 29, 2020 · 9 comments · Fixed by #2772
Labels
bug It's a bug stale An issue that hasn't been active for a while...

Comments

@mhimanshu712
Copy link

An issue with ElectronClient.

After adding a few elements in a list item ( NumberList, BulletedList ), if we press the Enter key, the last unused row should get deleted automatically which doesn't happen in Joplin.

Here is how it behaves:

jopnote

Here is how it should behave:

expectnote

@mhimanshu712 mhimanshu712 added the bug It's a bug label Feb 29, 2020
@mhimanshu712
Copy link
Author

mhimanshu712 commented Feb 29, 2020

Also, I would like to work on it.
@PackElend

@PackElend
Copy link
Contributor

second is how I'm used to it in MS TEAMS,
go ahead

@coderrsid
Copy link
Contributor

I guess it's not a bug , it's a note, user can leave the number for future addition to the list, that all depends on user. What do you suggest @tessus ?

@tessus
Copy link
Collaborator

tessus commented Mar 2, 2020

This is really a matter of opinion. I've found the current behavior a bit annoying. But that's just me.

If I wanted to add a new item, I would just position the cursor at the end of the last item and hit enter.

@PackElend
Copy link
Contributor

If I wanted to add a new item, I would just position the cursor at the end of the last item and hit enter.

me too, I like it slim

@Rishabh-malhotraa
Copy link
Contributor

@laurent22 what do you think about this, should I go ahead trying to fix this?

@stale
Copy link

stale bot commented Apr 16, 2020

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

@stale stale bot added the stale An issue that hasn't been active for a while... label Apr 16, 2020
@stale
Copy link

stale bot commented Apr 24, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Apr 24, 2020
@tessus
Copy link
Collaborator

tessus commented Apr 25, 2020

There's a PR available. I've been using the code for weeks now and it works splendidly.

It will get merged eventually.

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug stale An issue that hasn't been active for a while...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants