All: 1383 Clear selected Notes when switching Notebook

[tkilaker]

This commit will fix #1383.

Tried several fixes, but I think this kind of quick-n-dirty fix is the most reasonable. Debugging shows that the root issue surrounds that the render method at NoteTest.jsx is run frequently, and a timing issue in the state can occur. Pausing on a break point actually "fixed" the issue.

[laurent22]

Thanks for the pull request, but if a note is empty in this array, we'll need to find the root cause of it. If it's unavoidable due to some race condition, then maybe we should exit the function, or remove the empty note from the array before processing it in the function.

[tkilaker]

Yes, it's a race condition. I did not see a trivial fix for it. I've amended the commit so that it will exit the function if any Note is null.

[laurent22]

I think the issue is that the selected notes are not reset in the FOLDER_SELECT action (in the reducer). If they are set to an empty array in there, it should fix this (and potentially other issues).

[tkilaker]

I agree, that was what I was looking for. Thanks for the assistance!
And sorry for the temporary Git mess.

[laurent22]

Looks good, thanks for the fix!