Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short certificate listing by default #78

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Short certificate listing by default #78

merged 2 commits into from
Mar 8, 2024

Conversation

lnussel
Copy link
Contributor

@lnussel lnussel commented Feb 28, 2024

Also add -a option to list all databases

# mokutil -l -a
[MokListRT]
4659838c82 openSUSE Secure Boot CA
[MokListXRT]
0000000000 (sha256)
[PK]
bca4e38ed1 SUSE Linux Enterprise Secure Boot CA
[KEK]
bca4e38ed1 SUSE Linux Enterprise Secure Boot CA
31590bfd89 Microsoft Corporation KEK CA 2011
[db]
580a6f4cc4 Microsoft Windows Production PCA 2011
46def63b5c Microsoft Corporation UEFI CA 2011
[dbx]
e3b0c44298 (sha256)

@lnussel
Copy link
Contributor Author

lnussel commented Feb 28, 2024

fixes #62

@lcp
Copy link
Owner

lcp commented Mar 4, 2024

Thanks for the patch. I'll review the patch soon.

@lnussel
Copy link
Contributor Author

lnussel commented Mar 6, 2024

updated

@lcp
Copy link
Owner

lcp commented Mar 8, 2024

Thanks!

@lcp lcp merged commit 8ba3ffb into lcp:master Mar 8, 2024
@iokomin
Copy link

iokomin commented Mar 11, 2024

@lcp @lnussel apologize for this late comment

Changing default behavior may affect existing customer environments and automation scripts which already depend on the detailed output.
All in all feature looks great, the only concern from my side is this default behavior change, as it may be considered as a sort of "breaking change" to take into account.

@lcp
Copy link
Owner

lcp commented Mar 12, 2024

@lcp @lnussel apologize for this late comment

Changing default behavior may affect existing customer environments and automation scripts which already depend on the detailed output. All in all feature looks great, the only concern from my side is this default behavior change, as it may be considered as a sort of "breaking change" to take into account.

You are right. This change could break the old scripts. I was in a hurry to merge new patches and fix the versioning issue and didn't think it thoroughly. I'm considering to flip the default listing method to verbose for 0.7.2.

@lnussel
Copy link
Contributor Author

lnussel commented Apr 16, 2024

well, don't submit to SLE. For TW just do it. The world is changing and this is not exactly the most critical user facing tooling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants