edit env files to remove bas-apres #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkingslake
changed the title
Minimum allowed line rate is |
jkingslake
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves some issues with the GH action tests failing.
I tried various things that didnt help (e.g. removing and re-adding bas-apres submodule).
Finally what helped was to remove bas-apres from the ci environment yaml. What must have been happening was the repo and submodule were getting checked out ok by the GH action, but then bas-apres was getting pip installed. The version which gets pip installed is an old version which doesnt have the latest changes and it was this version which was getting found when importing bas-apres in xapres.
I also edited one test which was failing to load dat files from the google bucket due to too many attempts being made. I just reduced the number it was trying to do from 3 to 1 and it worked fine.
Also I edited the changelog in preparation for the next release.