Skip to content

Commit 860f0cb

Browse files
committed
chore(Data.NNRat.Defs): reduce imports (#14541)
A more straightforward proof and we can reduce the explicit imports for `Data.NNRat.Defs` by a third.
1 parent a90eae7 commit 860f0cb

File tree

10 files changed

+9
-10
lines changed

10 files changed

+9
-10
lines changed

Mathlib/Data/Int/Star.lean

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Authors: Yaël Dillies
55
-/
66
import Mathlib.Algebra.Star.Order
77
import Mathlib.Algebra.Order.Monoid.Submonoid
8+
import Mathlib.Algebra.Order.Ring.Basic
89

910
/-!
1011
# Star ordered ring structure on `ℤ`

Mathlib/Data/NNRat/Defs.lean

+2-7
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ Authors: Yaël Dillies, Bhavik Mehta
55
-/
66
import Mathlib.Algebra.Order.Nonneg.Ring
77
import Mathlib.Algebra.Order.Ring.Rat
8-
import Mathlib.Data.Int.Lemmas
98

109
#align_import data.rat.nnrat from "leanprover-community/mathlib"@"b3f4f007a962e3787aa0f3b5c7942a1317f7d88e"
1110

@@ -32,7 +31,6 @@ Whenever you state a lemma about the coercion `ℚ≥0 → ℚ`, check that Lean
3231
`Subtype.val`. Else your lemma will never apply.
3332
-/
3433

35-
3634
open Function
3735

3836
deriving instance CanonicallyOrderedCommSemiring for NNRat
@@ -376,11 +374,8 @@ lemma coprime_num_den (q : ℚ≥0) : q.num.Coprime q.den := by simpa [num, den]
376374
@[simp] lemma den_ofNat (n : ℕ) [n.AtLeastTwo] : den (no_index (OfNat.ofNat n)) = 1 := rfl
377375

378376
theorem ext_num_den (hn : p.num = q.num) (hd : p.den = q.den) : p = q := by
379-
refine ext <| Rat.ext ?_ ?_
380-
· apply (Int.natAbs_inj_of_nonneg_of_nonneg _ _).1 hn
381-
· exact Rat.num_nonneg.2 p.2
382-
· exact Rat.num_nonneg.2 q.2
383-
· exact hd
377+
refine ext <| Rat.ext ?_ hd
378+
simpa [num_coe]
384379
#align nnrat.ext_num_denom NNRat.ext_num_den
385380

386381
theorem ext_num_den_iff : p = q ↔ p.num = q.num ∧ p.den = q.den :=

Mathlib/Data/Nat/Digits.lean

+1-1
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ theorem digits_two_eq_bits (n : ℕ) : digits 2 n = n.bits.map fun b => cond b 1
628628
cases b
629629
· rw [digits_def' one_lt_two]
630630
· simpa [Nat.bit, Nat.bit0_val n]
631-
· simpa [pos_iff_ne_zero, Nat.bit0_eq_zero]
631+
· simpa [Nat.bit, pos_iff_ne_zero, Nat.bit0_eq_zero]
632632
· simpa [Nat.bit, Nat.bit1_val n, add_comm, digits_add 2 one_lt_two 1 n, Nat.add_mul_div_left]
633633
#align nat.digits_two_eq_bits Nat.digits_two_eq_bits
634634

Mathlib/Data/Nat/Fib/Basic.lean

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Authors: Kevin Kappelmann, Kyle Miller, Mario Carneiro
66
import Mathlib.Algebra.BigOperators.Group.Finset
77
import Mathlib.Data.Finset.NatAntidiagonal
88
import Mathlib.Data.Nat.GCD.Basic
9+
import Mathlib.Data.Nat.Bits
910
import Mathlib.Init.Data.Nat.Lemmas
1011
import Mathlib.Logic.Function.Iterate
1112
import Mathlib.Tactic.Ring

Mathlib/Data/Nat/Hyperoperation.lean

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ Copyright (c) 2023 Mark Andrew Gerads. All rights reserved.
33
Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: Mark Andrew Gerads, Junyan Xu, Eric Wieser
55
-/
6-
import Mathlib.Algebra.Order.Ring.Abs
76
import Mathlib.Tactic.Ring
87

98
#align_import data.nat.hyperoperation from "leanprover-community/mathlib"@"f7fc89d5d5ff1db2d1242c7bb0e9062ce47ef47c"

Mathlib/Data/Nat/Nth.lean

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ Copyright (c) 2021 Vladimir Goryachev. All rights reserved.
33
Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: Yaël Dillies, Vladimir Goryachev, Kyle Miller, Scott Morrison, Eric Rodriguez
55
-/
6+
import Mathlib.Data.List.GetD
67
import Mathlib.Data.Nat.Count
78
import Mathlib.Data.Nat.SuccPred
89
import Mathlib.Order.Interval.Set.Monotone

Mathlib/Data/Num/Prime.lean

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Authors: Mario Carneiro
66
import Mathlib.Data.Num.Lemmas
77
import Mathlib.Data.Nat.Prime.Defs
88
import Mathlib.Tactic.Ring
9+
import Mathlib.Algebra.Ring.Divisibility.Basic
910

1011
#align_import data.num.prime from "leanprover-community/mathlib"@"58581d0fe523063f5651df0619be2bf65012a94a"
1112

Mathlib/Data/Rat/Star.lean

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: Jireh Loreaux, Yaël Dillies
55
-/
66
import Mathlib.Algebra.GroupWithZero.Commute
7+
import Mathlib.Algebra.Order.Ring.Abs
78
import Mathlib.Algebra.Star.Order
89
import Mathlib.Data.NNRat.Lemmas
910
import Mathlib.Algebra.Order.Monoid.Submonoid

Mathlib/NumberTheory/EllipticDivisibilitySequence.lean

-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ Copyright (c) 2024 David Kurniadi Angdinata. All rights reserved.
33
Released under Apache 2.0 license as described in the file LICENSE.
44
Authors: David Kurniadi Angdinata
55
-/
6-
import Mathlib.Algebra.Order.Ring.Abs
76
import Mathlib.Data.Nat.EvenOddRec
87
import Mathlib.Tactic.Linarith
98
import Mathlib.Tactic.LinearCombination

scripts/noshake.json

+1
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,7 @@
214214
"Mathlib.Tactic.Positivity.Basic":
215215
["Mathlib.Algebra.GroupPower.Order",
216216
"Mathlib.Algebra.Order.Group.PosPart",
217+
"Mathlib.Algebra.Order.Ring.Basic",
217218
"Mathlib.Data.Int.CharZero",
218219
"Mathlib.Data.Nat.Factorial.Basic",
219220
"Mathlib.Data.PNat.Defs"],

0 commit comments

Comments
 (0)