-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Data.NNRat.Defs): reduce imports #14541
Conversation
PR summary db3fccb641
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Data.NNRat.Defs | 458 | 444 | -14 (-3.06%) |
Mathlib.Data.Nat.Hyperoperation | 504 | 490 | -14 (-2.78%) |
Mathlib.Data.Int.Star | 523 | 510 | -13 (-2.49%) |
Mathlib.Data.Rat.Star | 540 | 529 | -11 (-2.04%) |
Mathlib.NumberTheory.EllipticDivisibilitySequence | 535 | 527 | -8 (-1.50%) |
Mathlib.Data.Nat.Fib.Basic | 617 | 608 | -9 (-1.46%) |
Mathlib.Data.Nat.Nth | 658 | 650 | -8 (-1.22%) |
Mathlib.Data.Num.Prime | 547 | 542 | -5 (-0.91%) |
Mathlib.Data.Nat.Digits | 658 | 653 | -5 (-0.76%) |
Import changes for all files
Files | Import difference |
---|---|
Too many changes (364)! |
Declarations diff
No declarations were harmed in the making of this PR! 🐙
You can run this locally as follows
## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit>
Looks great; thanks! Feel free to maintainer merge on my behalf. The CI failure looks intermittent; I've just retried it. (Edit: now CI actually runs) |
CI passes, the changes still look good to me - thank you for doing this! |
🚀 Pull request has been placed on the maintainer queue by grunweg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
A more straightforward proof and we can reduce the explicit imports for `Data.NNRat.Defs` by a third.
Pull request successfully merged into master. Build succeeded: |
A more straightforward proof and we can reduce the explicit imports for
Data.NNRat.Defs
by a third.