[Merged by Bors] - feat: add an eval% elaborator for interpolating the output of #eval
#10742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
t-meta
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
eric-wieser
commented
Feb 20, 2024
test/eval_elab.lean
Outdated
Comment on lines
29
to
39
| /-- `Finset α` can be converted to an expr only if there is some way to find `DeciableEq α`. -/ | ||
| unsafe nonrec instance Finset.toExpr | ||
| {α : Type u} [ToLevel.{u}] [ToExpr α] [HasInstance (DecidableEq α)] : ToExpr (Finset α) := | ||
| have u' : Level := ToLevel.toLevel.{u} | ||
| have α' : Q(Type u') := Lean.ToExpr.toTypeExpr α | ||
| letI : Q(DecidableEq $α') := HasInstance.expr (DecidableEq α) | ||
| { toTypeExpr := q(Finset $α') | ||
| toExpr := fun x => show Q(Finset $α') from | ||
| match show List Q($α') from x.val.unquot.reverse.map toExpr with | ||
| | [] => q(∅) | ||
| | x0 :: xs => List.foldl (fun s x => q(insert $x $s)) q({$x0}) xs } |
There was a problem hiding this comment.
This would be a lot cleaner with #5952, but that PR is not ready to merge yet, and this is just a test file anyway.
adomani
reviewed
Feb 20, 2024
Co-authored-by: damiano <[email protected]>
adomani
reviewed
Feb 20, 2024
Co-authored-by: damiano <[email protected]>
adomani
reviewed
Feb 20, 2024
adomani
reviewed
Feb 20, 2024
leanprover-community-mathlib4-bot
added
the
merge-conflict
eric-wieser
removed
the
merge-conflict
leanprover-community-mathlib4-bot
added
the
merge-conflict
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
Is this expected to work with let-bound vars? e.g. example : True := let a := 2; let b := eval% a * 2At the moment we get some horrible fvar error: |
|
That's not expected to work; though it could certainly give a better message. You could always put the |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
|
For a future version, it would be nice if it could capture local One way to implement this: figure out which variables would need to be reverted, throw an error if any of them are not |
Co-authored-by: Kyle Miller <[email protected]>
|
bors merge Perhaps worth noting that this won't handle universe variables correctly until leanprover/lean4#3090 lands. |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
|
Build failed:
|
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
eval% elaborator for interpolating the output of #evaleval% elaborator for interpolating the output of #eval
dagurtomas
pushed a commit
that referenced
this pull request
Mar 22, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
utensil
pushed a commit
that referenced
this pull request
Mar 26, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
Louddy
pushed a commit
that referenced
this pull request
Apr 15, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
uniwuni
pushed a commit
that referenced
this pull request
Apr 19, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
callesonne
pushed a commit
that referenced
this pull request
Apr 22, 2024
…l` (#10742) This is taken from [my zulip message here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/How.20to.20simplify.20this.20proof.20without.20using.20a.20have.20statement.3F/near/422294189). As an example: ```lean example : 2^10 = eval% 2^10 := by -- goal is `2^10 = 1024` sorry ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is taken from my zulip message here.
As an example: